Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenTransformer script - convert px to REMs in CSS #10051

Open
2 of 9 tasks
alisonailea opened this issue Aug 13, 2024 · 4 comments
Open
2 of 9 tasks

TokenTransformer script - convert px to REMs in CSS #10051

alisonailea opened this issue Aug 13, 2024 · 4 comments
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. Calcite (design) Issues logged by Calcite designers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
Stalled

Comments

@alisonailea
Copy link
Contributor

alisonailea commented Aug 13, 2024 •
edited
Loading

Check existing issues

Description

create token transformer script to convert semantic space, size, and font-size tokens to REMs.

Acceptance Criteria

  • npm --workspace="packages/calcite-design-tokens" run build
  • open the calcite-design-tokens/dist/css/global.css file
  • confirm space, size, and font-size tokens are in REMs

Relevant Info

Use StyleDictionary plugin https://amzn.github.io/style-dictionary/#/transforms?id=sizepxtorem

Which Component

calcite-design-tokens

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@alisonailea alisonailea added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 13, 2024
@alisonailea alisonailea self-assigned this Aug 13, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 13, 2024
@alisonailea alisonailea added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 5 A few days of work, definitely requires updates to tests. and removed 0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels Aug 13, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 13, 2024
This was referenced Aug 13, 2024
Open
Open
@alisonailea
Copy link
Contributor Author

This no longer requires a custom transformer script once we change over to Style Dictionary 4 with TokenStudio 1 transformers. That work is in progress here https://github.com/Esri/calcite-design-system/compare/astump/style-dictionary-4.x

@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 15, 2025
@geospatialem
Copy link
Member

This no longer requires a custom transformer script once we change over to Style Dictionary 4 with TokenStudio 1 transformers. That work is in progress here https://github.com/Esri/calcite-design-system/compare/astump/style-dictionary-4.x

@alisonailea Which milestone do you want to target for inclusion?

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 15, 2025
@alisonailea
Copy link
Contributor Author

Will be merged with #11391

@brittneytewks brittneytewks added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Feb 10, 2025
@geospatialem
Copy link
Member

Blocked by #11391

@geospatialem geospatialem mentioned this issue Feb 24, 2025
Open
86 tasks
@geospatialem geospatialem added 0 - new New issues that need assignment. blocked This issue is blocked by another issue. and removed 2 - in development Issues that are actively being worked on. labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. Calcite (design) Issues logged by Calcite designers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @geospatialem @brittneytewks