Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "permafrost" soil #1547

Open
sierra-moxon opened this issue Oct 29, 2024 · 2 comments
Open

add "permafrost" soil #1547

sierra-moxon opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
simple fix Straightforward issue with a simple solution and limited discussion required.

Comments

@sierra-moxon
Copy link
Contributor

Looking at the subclass hiearchy under "soil" - https://www.ebi.ac.uk/ols4/ontologies/envo/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FENVO_00001998?lang=en

I think we maybe missing the soil component of permafrost. Or we need to think about adding "permafrost" to the soil subclass hierarchy.

@pbuttigieg
Copy link
Member

Permafrosts can lack soil altogether, but we can try to add a class for soil in a permafrost "state"

@timalamenciak
Copy link
Contributor

I see that the existing entry for permafrost (ENVO:00000134) has one of its axioms as composed primarily of some (rock or soil or sediment). Would the reasoner not then associate that with soil? (I legitimately don't know much about how the reasoner works)

So then the subclass of soil would refer to the soil component only (not rock or sediment).

Maybe:

permafrost soil - def: Soil which is at or below the freezing point of water for two or more years

and as an axiom - part of some permafrost?

I'm happy to make this change if it addresses Sierra's comment and fits with everything.

@timalamenciak timalamenciak added the simple fix Straightforward issue with a simple solution and limited discussion required. label Feb 21, 2025
@timalamenciak timalamenciak self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simple fix Straightforward issue with a simple solution and limited discussion required.
Projects
None yet
Development

No branches or pull requests

3 participants