From 103fa11a5efba016120a91ff6f5ce5880a0afd56 Mon Sep 17 00:00:00 2001 From: Jack Blower Date: Thu, 23 Nov 2023 16:32:57 +0000 Subject: [PATCH 1/2] feat: Expose the App Gateway's IP Address name --- azurerm/modules/azurerm-app-gateway/data.tf | 5 +++++ azurerm/modules/azurerm-app-gateway/outputs.tf | 11 +++++------ 2 files changed, 10 insertions(+), 6 deletions(-) create mode 100644 azurerm/modules/azurerm-app-gateway/data.tf diff --git a/azurerm/modules/azurerm-app-gateway/data.tf b/azurerm/modules/azurerm-app-gateway/data.tf new file mode 100644 index 00000000..6f4c4f05 --- /dev/null +++ b/azurerm/modules/azurerm-app-gateway/data.tf @@ -0,0 +1,5 @@ +data "azurerm_public_ip" "default" { + name = azurerm_public_ip.app_gateway.name + resource_group_name = var.resource_group_name + depends_on = [azurerm_public_ip.app_gateway] +} diff --git a/azurerm/modules/azurerm-app-gateway/outputs.tf b/azurerm/modules/azurerm-app-gateway/outputs.tf index 5fc8aa7a..e73dd306 100644 --- a/azurerm/modules/azurerm-app-gateway/outputs.tf +++ b/azurerm/modules/azurerm-app-gateway/outputs.tf @@ -1,9 +1,3 @@ -data "azurerm_public_ip" "default" { - name = azurerm_public_ip.app_gateway.name - resource_group_name = var.resource_group_name - depends_on = [azurerm_public_ip.app_gateway] -} - output "app_gateway_resource_group_name" { description = "Resource group of the application gateway" value = azurerm_public_ip.app_gateway.resource_group_name @@ -19,6 +13,11 @@ output "app_gateway_ip" { value = data.azurerm_public_ip.default.ip_address } +output "app_gateway_ip_name" { + description = "Application Gateway public IP name. Should be used with DNS provider at a top level. Can have multiple subs pointing to it - e.g. app.sub.domain.com, app-uat.sub.domain.com. App Gateway will perform SSL termination for all " + value = azurerm_public_ip.app_gateway.name +} + output "certificate_pem" { description = "PEM key of certificate, can be used internally" value = var.create_valid_cert ? acme_certificate.default.0.certificate_pem : tls_self_signed_cert.self_cert.0.cert_pem From a4bff8b53a3f37b633eae8b485dab5514a7f31d5 Mon Sep 17 00:00:00 2001 From: Jack Blower Date: Thu, 23 Nov 2023 16:35:31 +0000 Subject: [PATCH 2/2] fix: ff --- azurerm/modules/azurerm-app-gateway/outputs.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/azurerm/modules/azurerm-app-gateway/outputs.tf b/azurerm/modules/azurerm-app-gateway/outputs.tf index e73dd306..f0afd3b5 100644 --- a/azurerm/modules/azurerm-app-gateway/outputs.tf +++ b/azurerm/modules/azurerm-app-gateway/outputs.tf @@ -9,12 +9,12 @@ output "app_gateway_name" { } output "app_gateway_ip" { - description = "Application Gateway public IP. Should be used with DNS provider at a top level. Can have multiple subs pointing to it - e.g. app.sub.domain.com, app-uat.sub.domain.com. App Gateway will perform SSL termination for all " + description = "Application Gateway public IP. Should be used with DNS provider at a top level. Can have multiple subs pointing to it - e.g. app.sub.domain.com, app-uat.sub.domain.com. App Gateway will perform SSL termination for all" value = data.azurerm_public_ip.default.ip_address } output "app_gateway_ip_name" { - description = "Application Gateway public IP name. Should be used with DNS provider at a top level. Can have multiple subs pointing to it - e.g. app.sub.domain.com, app-uat.sub.domain.com. App Gateway will perform SSL termination for all " + description = "Application Gateway public IP name" value = azurerm_public_ip.app_gateway.name }