Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Replace custom calendar with kizitonwose/Calendar #218

Open
19 tasks done
EmmaTellblom opened this issue Jan 15, 2025 · 7 comments · May be fixed by #224
Open
19 tasks done

[FEATURE] Replace custom calendar with kizitonwose/Calendar #218

EmmaTellblom opened this issue Jan 15, 2025 · 7 comments · May be fixed by #224
Labels
Milestone

Comments

@EmmaTellblom
Copy link
Owner

EmmaTellblom commented Jan 15, 2025

Replace the custom calendar that is in the app today with a vertically scrolled calendar from kizitonwose/Calendar repo. This will enable us to let user choose start day of week and customize the calendar in a better way.

Stuff to fix in the new calendar

  • Add/remove perioddates
  • Add/remove ovulation
  • Add/remove symptoms
  • Show symptoms
  • Show predicted Period
  • Show predicted Ovulation
  • Show passed Period
  • Show passed Ovulation
  • Selection of date(s)
  • Todays date
  • Cyclenumbers
  • Fix texts on buttons (add/remove)
  • Fix enable/disable on buttons
  • Notifications
  • Use predifined lists instead of local for month name and day names
  • New setting in database for weekday
  • Dynamic fetch of start weekday in calendar screen
  • Weekstart in settings
  • Fix translation fields for new settings (changing of startday for week in calendar)
@EmmaTellblom EmmaTellblom added this to the Version 2.0 milestone Jan 15, 2025
@EmmaTellblom
Copy link
Owner Author

I have decided to deprecate "selected period color" and only go with "selected color". This is because we dont have a color for "selection of ovulation". Its a bit overkill to have a distinct color for selecting a period date. You would probably know that you have selected a period date anyways.

@EmmaTellblom
Copy link
Owner Author

I added three new db-functions that returns dates for focused month, but also previous month and following month. This is due to bigger screens will be able to show more than one month at a time and it would be nice for the user to have all of the data at one glance.

Issues;
val startMonth = remember { currentMonth.minusMonths(50) } // Adjust as needed
val endMonth = remember { currentMonth.plusMonths(50) } // Adjust as needed

I would rather we didn't have these variables because I don't want to limit the user to 50 months back/future. But haven't figured out how to make it dynamic yet.

@EmmaTellblom
Copy link
Owner Author

Startday of week will not be implemented as a setting. We will fetch this from the users locale instead. If there are users who would want us to have this as a seperate setting, then we will look at implementing it.

@carstenhag
Copy link
Collaborator

carstenhag commented Feb 21, 2025

@EmmaTellblom I was thinking of #199 again. I don't want to introduce an icon to get the user back to "today". But we could make the "Calendar" title tappable and make that focus the curent month, what do you think?

Edit:
Ambrodust had said just that some weeks ago: "Any chance hitting the calendar button could take you back to today? The one on the bottom menu"

@carstenhag
Copy link
Collaborator

Oh no, it looks terrible on landscape mode :( We have to fix this for sure. I'll check the UX discussions we had and work on something the next days I hope.

Image

@EmmaTellblom
Copy link
Owner Author

@carstenhag Yes pressing calendar would be a great way to focus to current month again!
Agree that we need to think about landscape. But the issue is also that in landscape height is very limited so not sure how we can improve?

@carstenhag
Copy link
Collaborator

carstenhag commented Feb 21, 2025

The buttons have to go away in one way or another. Or at least get smaller.
But also, the calendar boxes are too big in landscape

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants