Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of reqwest rustls-tls-webpki-roots #25

Closed
alexanderkjall opened this issue Sep 2, 2023 · 1 comment
Closed

usage of reqwest rustls-tls-webpki-roots #25

alexanderkjall opened this issue Sep 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@alexanderkjall
Copy link

Is your feature request related to a problem? Please describe.

I'm looking at packaging this for Debian, and noticed the usage of reqwest/rustls-tls-webpki-roots, this collides with our packaging policies as it duplicates the ca-certs into the binary, so that the binary have to be rebuilt if there is an update to the ca-certs.

Describe the solution you'd like

Use reqwest/rustls-tls-native-roots instead.

Describe alternatives you've considered

I can just patch the crate to use reqwest/rustls-tls-native-roots myself, but I thought that I should also bring this up here, in order to keep the diff between

Additional context

Technically this should maybe be a security issue, since it will be a security problem if a ca-cert gets compromised and the binary isn't rebuilt. But since it's so theoretical and other debate about the usage of webpki-roots is public I don't think there is a need to keep this secret.

Also see this comment for an analysis of the situation: rust-lang/rustup#3400 (comment)

@alexanderkjall alexanderkjall added the enhancement New feature or request label Sep 2, 2023
@Jake-Shadle
Copy link
Member

Disable default features and enable native-certs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants