Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement options(noreturn) for asm!. #570

Closed
XAMPPRocky opened this issue Mar 31, 2021 · 0 comments · Fixed by #717
Closed

Implement options(noreturn) for asm!. #570

XAMPPRocky opened this issue Mar 31, 2021 · 0 comments · Fixed by #717
Labels
a: asm Issues related to inline assembly. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: enhancement A new feature or improvement to an existing one.

Comments

@XAMPPRocky
Copy link
Member

Currently you cannot correctly write an inline assembly that uses a terminator, as there's no way to specify options(noreturn). This means for example that we can't set functions that use these terminators to -> ! to be able to behave like panic! from std.
@XAMPPRocky XAMPPRocky added a: asm Issues related to inline assembly. t: enhancement A new feature or improvement to an existing one. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. labels Mar 31, 2021
@XAMPPRocky XAMPPRocky mentioned this issue Mar 31, 2021
Closed
@msiglreith msiglreith mentioned this issue Apr 17, 2021
Merged
@msiglreith msiglreith mentioned this issue Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: asm Issues related to inline assembly. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: enhancement A new feature or improvement to an existing one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

asm: add support for noreturn option msiglreith/rust-gpu
1 participant
@XAMPPRocky