Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error code in case of warnings #203

Closed
Niederb opened this issue Sep 28, 2022 · 1 comment
Closed

Return error code in case of warnings #203

Niederb opened this issue Sep 28, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Niederb
Copy link

Niederb commented Sep 28, 2022

Is your feature request related to a problem? Please describe.
For our CI I would like the execution of cargo-about to return an error code if there are any warnings (e.g. crate XY doesnt have a license field`) such that our build pipeline would fail if there are any warnings. Currently it is easy to overlook these warnings.

Describe the solution you'd like
It would be nice to have a config flag like fail-on-warning to support this use case.

Describe alternatives you've considered
We could also check/parse the output of cargo-about but I would prefer to just return an error code.
@Niederb Niederb added the enhancement New feature or request label Sep 28, 2022
@Niederb Niederb mentioned this issue Sep 28, 2022
Closed
@mikayla-maki mikayla-maki mentioned this issue Jan 23, 2023
Merged
3 tasks
@Jake-Shadle
Copy link
Member

Resolved by #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Niederb @Jake-Shadle