Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other proxy code cleanup tasks #52

Open
3 tasks
Eilon opened this issue Mar 11, 2024 · 0 comments
Open
3 tasks

Other proxy code cleanup tasks #52

Eilon opened this issue Mar 11, 2024 · 0 comments

Comments

@Eilon
Copy link
Owner

Eilon commented Mar 11, 2024

These tasks were originally noted in #43:

  • Consider renaming the proxy prefix to _proxy. Usually an underscore is used to differentiate 'built-in' features, which this would be.
  • Replace new GetKeyValuePairs() method with a built-in .NET API for parsing query string values
  • Consider changing the new JS method SendInvokeMessageToDotNetAsync to be another message type (we already have message type 0 (raw) and 1 (invoke method). It could then internally uses the new proxy mechanism, but perhaps not get mixed into the 'first-class' proxy feature? (This could make the actual proxy code a bit cleaner maybe?)

Note: #51 is specifically to address possible hangs due to sync-over-async usage of .Wait().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant