Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused event parameter from Table sorter onClick handler #935

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

sravichandran-eightfold
Copy link
Collaborator

SUMMARY:

Removing an unused event parameter in the Table Sorter onClick function

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-126322

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

This is a lint error

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sravichandran-eightfold sravichandran-eightfold merged commit c44c384 into main Jan 15, 2025
5 of 8 checks passed
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (0d0b03f) to head (4ffe1e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files        1100     1100           
  Lines       20513    20513           
  Branches     7759     7759           
=======================================
  Hits        17330    17330           
  Misses       3096     3096           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants