Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroller is interrupting with the mouse events even when it is not visible #920

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

spradhan-eightfold
Copy link
Contributor

@spradhan-eightfold spradhan-eightfold commented Dec 11, 2024

SUMMARY:

Left scroller button in Table row interrupts with mouse events like hover popup, even when it is not visible.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-121104

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  1. pull branch down locally and build and sync with vscode octuple module under node modules.
  2. Verify the hover on Demand pipeline page of resourcing.

Test plan for Eightfold

  1. Login as [email protected]
  2. Go to https://stage.eightfold.ai/demand/pipeline_v2?pid=26677650&query_id=D3VE7Z1j&review_mode=pipeline_v2_leads or any demand pipeline which has listed resources.
  3. Under the availability column, Verify that the availability popup is not getting interrupted.
  4. Attaching screen recording
    https://github.com/user-attachments/assets/ef054723-f38c-4450-9f49-10aaf5bde4ae

Copy link

codesandbox-ci bot commented Dec 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (f0b09c2) to head (613f744).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Table/Internal/Body/Scroller.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   84.61%   84.60%   -0.01%     
==========================================
  Files        1100     1100              
  Lines       20488    20490       +2     
  Branches     7748     7750       +2     
==========================================
  Hits        17335    17335              
- Misses       3066     3068       +2     
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spradhan-eightfold spradhan-eightfold merged commit 35efd65 into main Dec 12, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants