Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isequal: remove dep and replace with utility function derivation #833

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Removes @ngard/tiny-isequal dependency
  • Replace with a local, transcribed utility function
  • Removes old hacked type definition (my bad)

JIRA TASK (Eightfold Employees Only):

ENG-90064

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Test the DatePicker stories behave as expected.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dkilgore-eightfold dkilgore-eightfold merged commit 8f6222a into EightfoldAI:main May 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants