Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accordion: deep accessibility updates #823

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Apr 24, 2024

SUMMARY:

  • Removes multiple click target concern by moving overall clickable area inside the header, under the content via zIndex
  • Updates focus-visible styles to work with the new layout
  • Accounts for custom interactive content via selectors, such that it remains selectable or clickable
  • Checks if custom content is a string, wraps it in a span so it remains selectable
  • Removes a duplicate {...expandButtonProps} attribute
  • Updates unit tests
  • Updates stories

Lighthouse report:
accordionDeepA11yPassLighthouse

Axe report:
accordionDeepA11yPassAxe

JIRA TASK (Eightfold Employees Only):

ENG-87358

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Accordion stories behave as expected.

Copy link

codesandbox-ci bot commented Apr 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dkilgore-eightfold dkilgore-eightfold merged commit bc92489 into EightfoldAI:main May 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants