fix: menu: adds onclick handler back to main button when secondarybuttonprops fixing menu onchange #813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
The
onClick
event was deferred to the...rest
spread viaMenuItemButton
props, this caused a regression inMenu
as theonClick
callback was being used internally to triggerMenu
onChange
callback upstream.BEFORE FIX:
before.mp4
AFTER FIX:
after.mp4
JIRA TASK (Eightfold Employees Only):
ENG-85650
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theMenu
stories behave as expected.