Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssr: improve ssr support via globalobject this and use client strings #810

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds 'use client'; string to component files
  • Updates webpack to output globalObject: 'this'
  • Adds comments

JIRA TASK (Eightfold Employees Only):

ENG-85282

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify all components behave as expected.

Generate a local tarball using this guidance (internal only) --> https://eightfoldai.atlassian.net/l/cp/p2HdQHfh

clone https://github.com/EightfoldAI/qa-octuple

Read its README to learn about running the project locally

run yarn add <path to tarball> in the qa-octuple dir

run the project to ensure it runs using your new tarball

run yarn build to test nextjs build process.

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@gclark-eightfold gclark-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, though I think 'use client' could be omitted in places where React hooks aren't being used.

@dkilgore-eightfold dkilgore-eightfold merged commit e3a71f2 into EightfoldAI:main Apr 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants