feat: ssr: improve ssr support via globalobject this and use client strings #810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
'use client';
string to component filesglobalObject: 'this'
JIRA TASK (Eightfold Employees Only):
ENG-85282
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify all components behave as expected.Generate a local tarball using this guidance (internal only) --> https://eightfoldai.atlassian.net/l/cp/p2HdQHfh
clone https://github.com/EightfoldAI/qa-octuple
Read its
README
to learn about running the project locallyrun
yarn add <path to tarball>
in the qa-octuple dirrun the project to ensure it runs using your new tarball
run
yarn build
to test nextjs build process.