Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accordion: ensure expand button props are passed down to the button #808

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: accordion: ensure expand button props are passed down to the button #808

merged 1 commit into from
Apr 5, 2024

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Fixes issue where the prop was not being referenced as intended

JIRA TASK (Eightfold Employees Only):

ENG-84999

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Accordion story behaves as expected.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dkilgore-eightfold dkilgore-eightfold merged commit c423c40 into EightfoldAI:main Apr 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoward-eightfold jhoward-eightfold jhoward-eightfold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkilgore-eightfold @jhoward-eightfold