Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select: address selector scoping bugs when portal and right icon and export type #802

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Fixes bug where selected option styles were not being applied when dropdownProps={{ portal: true }} due to scoping
  • Fixes bug where right icon when present overlaps Select chevron if Select is filterable and clearable

JIRA TASK (Eightfold Employees Only):

ENG-83195

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Select stories behave as expected.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (4b121f4) to head (0670f8e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   84.38%   84.37%   -0.01%     
==========================================
  Files        1009     1009              
  Lines       19896    19896              
  Branches     7540     7540              
==========================================
- Hits        16789    16788       -1     
- Misses       3024     3025       +1     
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sbhatt-eightfold sbhatt-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkilgore-eightfold dkilgore-eightfold merged commit ca88b52 into EightfoldAI:main Mar 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants