Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grid: omit some attributes to avoid upstream linter errors when node lts #801

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Mar 20, 2024

SUMMARY:

Row and Col raise VS Code linter errors in React 18 + node 20 projects, omitting these, defining and making them optional should fix the issue.

JIRA TASK (Eightfold Employees Only):

ENG-83189

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Grid stories behave as expected.

Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (49526e9) to head (798549d).

❗ Current head 798549d differs from pull request most recent head a779721. Consider uploading reports for the commit a779721 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files        1009     1009           
  Lines       19901    19896    -5     
  Branches     7545     7540    -5     
=======================================
- Hits        16793    16790    -3     
+ Misses       3024     3023    -1     
+ Partials       84       83    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold
Copy link
Contributor Author

Turns out this is a known React 18 typing issue --> recharts/recharts#4382

@dkilgore-eightfold dkilgore-eightfold merged commit 41a4399 into EightfoldAI:main Apr 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants