Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accordion: enable custom summary layout using full width #799

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Mar 18, 2024

SUMMARY:

Enables custom full width Accordion AccordionSummary layouts, and adds more discreet custom props. Prior to this change, implementation of certain layouts was difficult because the header could not be easily made to fill the remaining space of the Accordion without using custom class names and css paths.

  • Adds fullWidth prop to AccordionSummary, setting the header and its container flex to 1 when enabled
  • Adds listStyle to List component to support inline customizing
  • Gives the Accordion a min-width so it doesn't clip its content when reflow in small screens
  • Adds a gap to the summary styles
  • Renames some internal variables
  • Adds onIconButtonClick callback
  • Passes iconButtonProps to the Button
  • Alphabetizes props
  • Adds Custom story
accordionReflow.mp4

JIRA TASK (Eightfold Employees Only):

ENG-80058

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Accordion stories behave as expected.

Copy link

codesandbox-ci bot commented Mar 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dkilgore-eightfold dkilgore-eightfold merged commit e66947d into EightfoldAI:main Apr 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants