Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use semantic card border color for cards #715

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jhoward-eightfold
Copy link
Contributor

SUMMARY:

This update corrects the card component to use the semantically named card-border-color instead of the generic border-color

GITHUB ISSUE (Open Source Contributors)

#701

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • pull down PR code
  • run storybook
  • in the card story, turn off dropshadow and turn on bordered
  • ensure card has a border color
  • inspect the element and confirm it is now using a semantic css vawriable

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91caa57:

Sandbox Source
React Configuration
Vanilla Configuration

@jhoward-eightfold jhoward-eightfold merged commit 48560d0 into EightfoldAI:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants