Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linkbutton: add link button component #607

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Apr 27, 2023

SUMMARY:

Adds LinkButton component and its variants mapped to those of Button
Updates useNudge to take styles from arguments
Updates OcBase/Base.types.ts to mark data-test-id as deprecated and adds data-testid
Exposes Button and adds a variant prop for less cumbersome implementation.
Exposes BreakPoints enum

LinkButton.mp4

JIRA TASK (Eightfold Employees Only):

ENG-27605

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn, yarn test and yarn storybook. Verify the Button and LinkButton stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 31f68d0:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0539a61). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage        ?   84.64%           
=======================================
  Files           ?      794           
  Lines           ?    17477           
  Branches        ?     6220           
=======================================
  Hits            ?    14794           
  Misses          ?     2617           
  Partials        ?       66           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit 8b3d782 into EightfoldAI:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants