-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: linkbutton: add link button component #607
feat: linkbutton: add link button component #607
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 31f68d0:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage ? 84.64%
=======================================
Files ? 794
Lines ? 17477
Branches ? 6220
=======================================
Hits ? 14794
Misses ? 2617
Partials ? 66 ☔ View full report in Codecov by Sentry. |
SUMMARY:
Adds
LinkButton
component and its variants mapped to those ofButton
Updates
useNudge
to takestyles
from argumentsUpdates
OcBase/Base.types.ts
to markdata-test-id
as deprecated and addsdata-testid
Exposes
Button
and adds avariant
prop for less cumbersome implementation.Exposes
BreakPoints
enumLinkButton.mp4
JIRA TASK (Eightfold Employees Only):
ENG-27605
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
,yarn test
andyarn storybook
. Verify theButton
andLinkButton
stories behave as expected.