Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar group): avatar group count, maxProps fixes #604

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

karurst-eightfold
Copy link
Contributor

@karurst-eightfold karurst-eightfold commented Apr 24, 2023

SUMMARY:

fix(avatar group): avatar group count, maxProps fixes.
The maxProps count is not being properly considered to show the correct count.
Having wrong counts shown when sent as children or avatarListProps -> fixed.
Avatar Group completely null rendered or moot when the numChildren available less then maxProps set -> fixed.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-50821

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

1.) Check the below stories of Avatar Group, the earlier wrongly shown counts are properly shown and in case of the octuple stories of Exceed MaxCount than children all avatars must render inline.

Screenshot 2023-04-25 at 1 01 40 AM

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de3e7d6:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@9ccf833). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage        ?   84.65%           
=======================================
  Files           ?      793           
  Lines           ?    17352           
  Branches        ?     6142           
=======================================
  Hits            ?    14690           
  Misses          ?     2596           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@karurst-eightfold karurst-eightfold merged commit 9bfa3f0 into EightfoldAI:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvatarGroup component doesn't show anything if only one item provided
3 participants