Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding mdi trend icons #585

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

yhoole-eightfold
Copy link
Contributor

@yhoole-eightfold yhoole-eightfold commented Apr 6, 2023

SUMMARY:

Adding the following new icons:

  • mdiTrendingDown
  • mdiTrendingNeutral
  • mdiTrendingUp

image

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

ENG-48906

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Tested in code sandbox

import "./styles.css";
import { IconName, Icon, IconSize } from "@eightfold.ai/octuple";

export default function App() {
  return (
    <div className="App">
      <Icon path={IconName.mdiTrendingDown} color="green" />
      <Icon path={IconName.mdiTrendingNeutral} color="red" />
      <Icon path={IconName.mdiTrendingUp} color="red" />
      
    </div>
  );
}

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c1dd1f1:

Sandbox Source
React Configuration
Vanilla Configuration

Copy link

@sanjeet-eightfold sanjeet-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you include the screenshot of what they look like before merging?

@yhoole-eightfold yhoole-eightfold changed the title Adding new icons to be used in calibration page feat: adding mdi trend icons Apr 7, 2023
src/components/Icon/mdi.ts Outdated Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit 56a04c7 into main Apr 7, 2023
@dkilgore-eightfold dkilgore-eightfold deleted the yhoole/octuple_trend_icons branch April 7, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants