Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select: options change not reacting properly when value is an object #570

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds object prop to SelectOption
  • Updates onOptionsChange callback to return values string array and its options object array
  • Updates unit tests to account for the newly added options argument returned by the onOptionsChange callback

GITHUB ISSUE (Open Source Contributors)

#562

JIRA TASK (Eightfold Employees Only):

ENG-46082

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Select stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43ca404:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@045ba0e). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage        ?   84.96%           
=======================================
  Files           ?      791           
  Lines           ?    16920           
  Branches        ?     5947           
=======================================
  Hits            ?    14376           
  Misses          ?     2478           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@slee-eightfold slee-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on PCS

@dkilgore-eightfold dkilgore-eightfold merged commit 1cba3fd into EightfoldAI:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants