-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stepper: Handle decimal scrollLeft value for scroll buttons #546
fix: stepper: Handle decimal scrollLeft value for scroll buttons #546
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4209b08:
|
Would be extra if you add a CSS modifier to give the small variant paddles some top margin. If not now, I can do this in a future change. You would need to account for horizontal vs vertical. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage ? 84.23%
=======================================
Files ? 790
Lines ? 16781
Branches ? 5886
=======================================
Hits ? 14135
Misses ? 2580
Partials ? 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…-eightfold/octuple into prathi/fix-stepper-scroll-buttons
SUMMARY:
ScrollLeft property can have decimal values for systems using display scaling (ref). Handle decimal values when deciding to disable scroll buttons.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-43824
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Before
Screen.Recording.2023-02-23.at.12.58.14.AM.mov
After
Screen.Recording.2023-02-23.at.12.58.27.AM.mov