Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stepper: Handle decimal scrollLeft value for scroll buttons #546

Conversation

prathi-eightfold
Copy link
Contributor

@prathi-eightfold prathi-eightfold commented Feb 22, 2023

SUMMARY:

ScrollLeft property can have decimal values for systems using display scaling (ref). Handle decimal values when deciding to disable scroll buttons.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-43824

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Before

Screen.Recording.2023-02-23.at.12.58.14.AM.mov

After

Screen.Recording.2023-02-23.at.12.58.27.AM.mov

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4209b08:

Sandbox Source
React Configuration
Vanilla Configuration

@dkilgore-eightfold
Copy link
Contributor

dkilgore-eightfold commented Feb 23, 2023

Would be extra if you add a CSS modifier to give the small variant paddles some top margin. If not now, I can do this in a future change. You would need to account for horizontal vs vertical.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@76304f3). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage        ?   84.23%           
=======================================
  Files           ?      790           
  Lines           ?    16781           
  Branches        ?     5886           
=======================================
  Hits            ?    14135           
  Misses          ?     2580           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@prathi-eightfold prathi-eightfold merged commit 49340dd into EightfoldAI:main Feb 23, 2023
@prathi-eightfold prathi-eightfold deleted the prathi/fix-stepper-scroll-buttons branch February 23, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants