fix: do not provide default colors for ConfigProvider #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoward-eightfold
requested review from
dkilgore-eightfold and
ychhabra-eightfold
and removed request for
dkilgore-eightfold
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec5f256:
|
dkilgore-eightfold
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
ConfigProvider is currently providing default values unnecessarily. This makes it necessary to provide empty objects in config in order to avoid the undesired default values.
In this example, I'm trying to emulate a starbucks green theme, and if I don't provide an empty navbarTheme and tabsTheme then the defaults get copied in and I end up with blue tabs despite my varTheme.
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull down the PR and run storybook locally. Select a new primary and/or accent color in ConfigProvider story. With this change, the tabs get updated appropriately. Current undesirable behavior is that they stay blue based on the default values.