Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroller for horizontally scrollable table #507

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

ychhabra-eightfold
Copy link
Collaborator

@ychhabra-eightfold ychhabra-eightfold commented Jan 18, 2023

SUMMARY:

feat: scroller for horizontally scrollable table

Screen.Recording.2023-01-18.at.10.02.38.PM.mov

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-39334

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5507d20:

Sandbox Source
React Configuration
Vanilla Configuration

src/components/Table/Internal/Body/Scroller.tsx Outdated Show resolved Hide resolved
src/components/Table/Internal/Body/Scroller.tsx Outdated Show resolved Hide resolved
src/components/Table/Internal/OcTable.tsx Outdated Show resolved Hide resolved
src/components/Table/Internal/Body/Scroller.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@6d0176f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage        ?   84.43%           
=======================================
  Files           ?      785           
  Lines           ?    16450           
  Branches        ?     5695           
=======================================
  Hits            ?    13889           
  Misses          ?     2494           
  Partials        ?       67           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ychhabra-eightfold ychhabra-eightfold merged commit e96f791 into EightfoldAI:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants