Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stepper: adds timeline variant #504

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Adds Stepper timeline variant
Fixes 2 A11y bugs by placing aria-hidden="true" on non li elements in ul
Fixes minor typo in Stepper
Adds classNames from props to mergedClasses of Stepper
Updates Stepper snaps and UTs

stepper.mp4

JIRA TASK (Eightfold Employees Only):

ENG-39994

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Stepper and Timeline stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e65469:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@65d51f0). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage        ?   84.79%           
=======================================
  Files           ?      784           
  Lines           ?    16361           
  Branches        ?     5672           
=======================================
  Hits            ?    13873           
  Misses          ?     2421           
  Partials        ?       67           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jhoward-eightfold jhoward-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to export the component anywhere or is it already covered by wildcard export of Stepper?

src/components/Stepper/Stepper.tsx Show resolved Hide resolved
src/components/Stepper/Stepper.tsx Outdated Show resolved Hide resolved
src/components/Stepper/Stepper.tsx Show resolved Hide resolved
src/components/Stepper/Stepper.tsx Outdated Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit 62f433f into EightfoldAI:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants