-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stepper: adds timeline variant #504
feat: stepper: adds timeline variant #504
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e65469:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage ? 84.79%
=======================================
Files ? 784
Lines ? 16361
Branches ? 5672
=======================================
Hits ? 13873
Misses ? 2421
Partials ? 67 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to export the component anywhere or is it already covered by wildcard export of Stepper?
SUMMARY:
Adds
Stepper
timeline
variantFixes 2 A11y bugs by placing
aria-hidden="true"
on nonli
elements inul
Fixes minor typo in
Stepper
Adds
classNames
from props tomergedClasses
ofStepper
Updates
Stepper
snaps and UTsstepper.mp4
JIRA TASK (Eightfold Employees Only):
ENG-39994
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theStepper
andTimeline
stories behave as expected.