Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectors: adds null value check to checkbox group onchange #497

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Compares for value in CheckBoxGroup onChange
  • Adds some typing

JIRA TASK (Eightfold Employees Only):

ENG-39406

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • [] Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the pr branch and run yarn and yarn storybook. Verify the CheckBoxGroup story behaves as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5bd89d1:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@80f9c6f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage        ?   84.87%           
=======================================
  Files           ?      784           
  Lines           ?    16297           
  Branches        ?     5622           
=======================================
  Hits            ?    13832           
  Misses          ?     2397           
  Partials        ?       68           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit b4a5dc2 into EightfoldAI:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants