Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export OcThemeNames from a better location #493

Closed
jhoward-eightfold opened this issue Jan 5, 2023 · 1 comment
Closed

export OcThemeNames from a better location #493

jhoward-eightfold opened this issue Jan 5, 2023 · 1 comment
Assignees
@dkilgore-eightfold
Labels
bug Something isn't working ticketed-internal Issue has an active ticket

Comments

@jhoward-eightfold
Copy link
Contributor

currently necessary to import OcThemeNames from deep:

import { OcThemeNames } from '@eightfold.ai/octuple/lib/components/ConfigProvider';

We should expose this at a more reasonable place. It should also be named singularly, as it presents only one value. OcThemeNames can be OcThemeName[]
@dkilgore-eightfold dkilgore-eightfold self-assigned this Jan 5, 2023
@dkilgore-eightfold dkilgore-eightfold added bug Something isn't working ticketed-internal Issue has an active ticket labels Jan 5, 2023
@dkilgore-eightfold
Copy link
Contributor

Tracking with ENG-39328

@dkilgore-eightfold dkilgore-eightfold mentioned this issue Jan 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkilgore-eightfold dkilgore-eightfold

Labels
bug Something isn't working ticketed-internal Issue has an active ticket
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkilgore-eightfold @jhoward-eightfold