Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: second icon on button #475

Merged
merged 6 commits into from
Jan 3, 2023

Conversation

mfazil-eightfold
Copy link
Contributor

@mfazil-eightfold mfazil-eightfold commented Dec 20, 2022

SUMMARY:

Added two icons button

With text
image

When the text is empty
image

As Dropdown

Screen.Recording.2022-12-21.at.7.38.32.PM.mov

Figma design:
https://www.figma.com/file/SlKRC7oKF7XZyHMv2op4ch/Octuple-DS-(Theme-2)?node-id=292%3A708&t=1XlyIUf3tu00a8ws-1
image

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-38311

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb7c78f:

Sandbox Source
React Configuration
Vanilla Configuration

@mfazil-eightfold mfazil-eightfold marked this pull request as ready for review December 20, 2022 13:15
@mfazil-eightfold mfazil-eightfold changed the title chore: initial push Two icons on button Dec 20, 2022
@ychhabra-eightfold ychhabra-eightfold changed the title Two icons on button feat: second icon on button Dec 21, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b3046fe). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage        ?   85.00%           
=======================================
  Files           ?      749           
  Lines           ?    16054           
  Branches        ?     5498           
=======================================
  Hits            ?    13646           
  Misses          ?     2347           
  Partials        ?       61           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mfazil-eightfold mfazil-eightfold merged commit d06a7aa into EightfoldAI:main Jan 3, 2023
@mfazil-eightfold mfazil-eightfold deleted the icon-button branch January 3, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants