-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: second icon on button #475
feat: second icon on button #475
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb7c78f:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage ? 85.00%
=======================================
Files ? 749
Lines ? 16054
Branches ? 5498
=======================================
Hits ? 13646
Misses ? 2347
Partials ? 61 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SUMMARY:
Added two icons button
With text
When the text is empty
As Dropdown
Screen.Recording.2022-12-21.at.7.38.32.PM.mov
Figma design:
https://www.figma.com/file/SlKRC7oKF7XZyHMv2op4ch/Octuple-DS-(Theme-2)?node-id=292%3A708&t=1XlyIUf3tu00a8ws-1
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-38311
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: