feat: varTheme based theming #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e823978:
|
dkilgore-eightfold
approved these changes
Dec 3, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage ? 84.63%
=======================================
Files ? 725
Lines ? 15766
Branches ? 5523
=======================================
Hits ? 13343
Misses ? 2355
Partials ? 68 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Initial implementation of exposing css var based via config provider. This will be extended to other components and leveraged to customize visual styling without having to write css.
GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
NA
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Manually testing in Storybook to ensure visuals are maintained in the button component suite. Additionally, testing configProvider updates in Storybook to ensure json based overriding of the css vars get applied as desired. Screenshot shows simple updates to remove pill shaped rounding and make primary buttons pink