Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of search box expandable #408

Merged
merged 15 commits into from
Oct 13, 2022

Conversation

mfazil-eightfold
Copy link
Contributor

SUMMARY:

Added expandable search box

Screen.Recording.2022-10-04.at.12.59.31.AM.mov

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-30444

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27db506:

Sandbox Source
React Configuration
Vanilla Configuration

src/components/Inputs/Input.types.ts Outdated Show resolved Hide resolved
src/components/Inputs/TextInput/TextInput.tsx Outdated Show resolved Hide resolved
src/components/Inputs/TextInput/TextInput.tsx Show resolved Hide resolved
src/components/Inputs/TextInput/TextInput.tsx Show resolved Hide resolved
src/components/Inputs/input.module.scss Show resolved Hide resolved
src/components/Inputs/input.module.scss Outdated Show resolved Hide resolved
src/components/Inputs/input.module.scss Outdated Show resolved Hide resolved
src/styles/themes/_definitions.scss Outdated Show resolved Hide resolved
src/styles/themes/_definitions.scss Outdated Show resolved Hide resolved
src/components/Inputs/Input.types.ts Show resolved Hide resolved
src/components/Inputs/input.module.scss Outdated Show resolved Hide resolved
src/styles/themes/_definitions.scss Outdated Show resolved Hide resolved
src/components/Inputs/input.module.scss Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@b65ef2c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage        ?   85.36%           
=======================================
  Files           ?      658           
  Lines           ?    13991           
  Branches        ?     4776           
=======================================
  Hits            ?    11943           
  Misses          ?     1993           
  Partials        ?       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/styles/themes/_definitions.scss Show resolved Hide resolved
src/components/Inputs/input.module.scss Show resolved Hide resolved
src/components/Inputs/input.module.scss Show resolved Hide resolved
src/components/Inputs/input.module.scss Show resolved Hide resolved
src/components/Inputs/Input.types.ts Show resolved Hide resolved
Copy link
Contributor

@jhoward-eightfold jhoward-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit with Dylan's approval. The visually looks much improved. Thank you for your extra effort

@dkilgore-eightfold dkilgore-eightfold merged commit aba0df7 into EightfoldAI:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants