Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: panel: add localization support to Panel, InfoBar #407

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Adds loc support to Panel and InfoBar.

JIRA TASK (Eightfold Employees Only):

ENG-31144

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist (loc tests)
  • I have added unittests for this change

TEST PLAN:

Pull the pr branch and do yarn, then yarn storybook, verify the Panel and InfoBar stories behave as expected.

Set the Panel or InfoBar locale to another language and test the close button aria label as follows (pseudo-code):

import { zhCN } from "@eightfold.ai/octuple/";
<Panel locale={zhCN} closeButtonAriaLabelText={'foo'} />

NOTE: The close button aria label text should read 'foo' when provided, else use the loc defaults.

also adds loc support to infobar, alphabetizes props
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9603705:

Sandbox Source
React Configuration
Vanilla Configuration

@dkilgore-eightfold dkilgore-eightfold merged commit 8413a18 into EightfoldAI:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants