Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slider: update to theme two, adds custom labels, and update value on click #383

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Updates Slider to use theme 2 styles
  • Adds rail/track click support to update values
  • Adds support for custom labels
  • Updates collision detection
  • Fixes thumb position on edges so the center of the thumb reflects the value
sliderImprovements.mp4

JIRA TASK (Eightfold Employees Only):

ENG-23861

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added/updated unittests for this change

TEST PLAN:

pull the pr branch and do yarn and yarn storybook. Verify the Slider story behaves as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c7b266e:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3982c91). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage        ?   84.83%           
=======================================
  Files           ?      485           
  Lines           ?    13288           
  Branches        ?     4480           
=======================================
  Hits            ?    11273           
  Misses          ?     1992           
  Partials        ?       23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit f42be3f into EightfoldAI:main Sep 20, 2022
@dkilgore-eightfold dkilgore-eightfold deleted the dkilgore-eightfold/slider-improvements branch June 6, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants