Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: label: add support for custom buttons and type clean up #366

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

The info button of the Label was rather brittle, this improves it a bit and add support for custom buttons.

labelButtons.mp4

JIRA TASK (Eightfold Employees Only):

ENG-29160

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the pr branch and do yarn and yarn storybook. Verify the Label stories behave as expected

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3037beb:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7a6f1e8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage        ?   89.28%           
=======================================
  Files           ?      484           
  Lines           ?    13071           
  Branches        ?     4395           
=======================================
  Hits            ?    11670           
  Misses          ?     1377           
  Partials        ?       24           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit 4e9f352 into EightfoldAI:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants