fix: button: use configprovider focus visible styles #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoward-eightfold
approved these changes
Aug 11, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f5d4f77:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
A recent update to remove some global resets to
<button>elements regressed thefocus-visiblestyles. This change fixes and applies the global style to all buttons in Octuple componentsJIRA TASK (Eightfold Employees Only):
ENG-26733
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
pull the pr branch and run
yarn, thenyarn installand verify via theConfigProviderstory the styles via tabbing around the components (excluding the color pickers). Or implement abuttonin aConfigProviderusing CodeSandbox CI.