Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds headerbuttonprops, headericon, bodypadding, and overlay props to surface ui #290

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Some scenarios require the following:

  • back button
  • no padding
  • no overlay

This change adds these props to support the above in Dialog, Modal and Panel

surfaceui.mp4

JIRA TASK (Eightfold Employees Only):

ENG-26194

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

pull the pr branch and do yarn, then yarn install, verify the chnages in the Dialog, Modal and Panel stories, or use the CodeSandbox CI url to build your own.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b6d2453:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@54b6418). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage        ?   88.39%           
=======================================
  Files           ?      385           
  Lines           ?    10438           
  Branches        ?     3539           
=======================================
  Hits            ?     9227           
  Misses          ?     1191           
  Partials        ?       20           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/components/Dialog/BaseDialog/BaseDialog.tsx Outdated Show resolved Hide resolved
src/components/Dialog/BaseDialog/base-dialog.module.scss Outdated Show resolved Hide resolved
src/components/Panel/Panel.tsx Show resolved Hide resolved
src/components/Panel/panel.module.scss Outdated Show resolved Hide resolved
@ychhabra-eightfold ychhabra-eightfold merged commit cbe4b87 into EightfoldAI:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants