Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination: fix onCurrentChange event getting fired on change of total #285

Merged

Conversation

ychhabra-eightfold
Copy link
Collaborator

SUMMARY:

fix: pagination: fix onCurrentChange event getting fired on change of total

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-25039

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3875a2:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@2825840). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage        ?   88.38%           
=======================================
  Files           ?      385           
  Lines           ?    10421           
  Branches        ?     3523           
=======================================
  Hits            ?     9211           
  Misses          ?     1190           
  Partials        ?       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2825840...c3875a2. Read the comment docs.

Copy link
Contributor

@mfazil-eightfold mfazil-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ychhabra-eightfold ychhabra-eightfold merged commit 74456a2 into EightfoldAI:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants