fix: css: scope normalize css reset to octuple components #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkilgore-eightfold
requested review from
ychhabra-eightfold and
jhoward-eightfold
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7443f7a:
|
jhoward-eightfold
approved these changes
Aug 2, 2022
src/components/Table/Tests/__snapshots__/Table.pagination.renders.shot
Outdated
Show resolved
Hide resolved
src/src/components/PersistentBar/__snapshots__/PersistentBar.stories.storyshot
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage ? 88.39%
=======================================
Files ? 385
Lines ? 10419
Branches ? 3523
=======================================
Hits ? 9210
Misses ? 1189
Partials ? 20 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Scopes normalize.css reset to components, keeps 2 low-risk, high ROI global resets.
Prior to this change https://github.com/necolas/normalize.css was being applied globally. This may contribute to css collisions within host apps. Scoping these resets will ensure only Octuple components will benefit.
Also adds vertical margins to menu items.
JIRA TASK (Eightfold Employees Only):
ENG-26154
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the pr and do
yarn, thenyarn install, verify all components using Storybook.