Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slider: fixes slider onresize event hang in react 16 #268

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Small change to fix component when host app uses react 16

JIRA TASK (Eightfold Employees Only):

ENG-25504

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull changes, downgrade React peer deps to React 16.14.0 deps and test Slider story

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@022151e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage        ?   88.37%           
=======================================
  Files           ?      384           
  Lines           ?    10334           
  Branches        ?     3464           
=======================================
  Hits            ?     9133           
  Misses          ?     1181           
  Partials        ?       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022151e...ac14f79. Read the comment docs.

@dkilgore-eightfold dkilgore-eightfold merged commit a03d14f into EightfoldAI:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants