From dd713faf78450e1bbebfd17064bbea67982892e1 Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 14:13:27 +0200 Subject: [PATCH 01/15] [CHUX-465] add Ebury logo with color --- public/ebury-logo-sm.png | Bin 0 -> 2532 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 public/ebury-logo-sm.png diff --git a/public/ebury-logo-sm.png b/public/ebury-logo-sm.png new file mode 100644 index 0000000000000000000000000000000000000000..2ad6056f283933da1f8d6efa721c0393e7d732c9 GIT binary patch literal 2532 zcmaJ@dpK148lKEfa!X1{r)?VdYOc&MgG$CQG%iErT4QEmVrGq*#f)LsmP&(McH^;2 zx}Xb6M|nyvJ4GtxUb~P>4&|;i386FEY41NyXFY4J-{pDV_xrxz_x|ydy1P1RsOqW0 zU@#4u6NRA|BNd;iin8MW_>0bjV%PvV?1enR5JAT4+kc(z6V$fnPU%`gKY<7tGOjbAmA%cNW4$l@jQE?ZE;IM6xJ_I_J z&bJ4`I8G7);3;wSVoAbTBsOx#c7%29;70g zfE_|+P^jNxDOR?~FbLw4F&L3Zgcg~jK|v@6MN-_+lyq89?^AdNA`o~7B zbh0g==jVV5tIa)@n1&1sw~0@hzDf*>t6l%RLp+&SqB~dPQ@f(hbPLK@ZehCc zdX1LGy=kZXBWJ>P`p4Dkc@+l7nhvRLNpu>S=*+2Tq>Da9ho^OB&i~dE9XgeLr+ua& z&b-I66L!=9E<+EEMqCE{>Wo_3o*bY20GwF9RuyfuZ{cLhWJR?}%lh?BM1G>|53MrK zmOJ_{$IdtUA+B@{42)gqE7_{;CJ+?g`>1=j)A4kzJ0C#mq^2*E7F}oysi@=UBkh7+ zT~p3pzm|En;XO^>P=GOh1LY5FJ@5W%;$6kdWW!^JHOh$7fg@w5tZY^~Hr7QMV>jr+ zX)JFhl8ca^&Y=3ugo%28f&aw z)yz3$Ets;ucTH0s(-7-zfL@zoW)Qb-U%WI)8i1T@zZ_q7E>`c|jfS3nJe?saI7;eK z3oyKRZuj)Pa=vw)^H5VM;mly{7Tp{dUtbnfcvF1e#=t4fB~Q0>Tg&DJl1H+<@w#af z2wNz1>0>9t4SM3o@x4LmmiuqCb*UhqM1CS+X%fbXxd-Czq|e@V;@b(EApcfB&K~a` zT>`EAfP9Ne8E0=XCt72zNxlWVMod;(YBAk1BpU8V9 zx8ql4zeS#$l~Gf5;>#n#qbzjnhgV=%;M-fVb?-!}eC8dsE`rj+z3Hdou*Oi7h`GyMa|5bP6WC%>koq}Ei5 zkvFI`{S{}xTx+C}%|7V`Sxy{{krhmmlwdR32=Qj{R&qpFeUuT|G?H2JG#s> zn!25r8((U+{WBzopj=**Dc`3&;QDXe&PyHwrwMndURA+P|Gts!hun?zHRnPIVdh*{ zeQM3d+RfK|P25aun{#Z`?C+tRgA$L2JQ7qnR5_{@m9(#GH^5{&WCKOwQ__Slm!7w- zu1 z6nSXoU^I@uuH-N@?@q&OO<-{cinGmv{NE-;>-irpZd}))!*x-Y(>#ezZZpsNb{nab z>?&aHI0)X+*jjyAcQf$mj@ESGsr?tPOoVUMZrgC{hD+|Y6|n8I_2w}_iR2MF`C{F9 zd(X%E!EY_YW;>&`=8>C18&8kPt74n$c5O5aN*Zyj*OaA|pLNkQywL0G{hZx#W^(2n zIWHBvIX$#j$x|uHmnKPhUR>!WvAIRCpJ*}<*sjdV>RWC7#|7tLH@yw=g2)^r)fIeRE8?TGYiJ|{i3dZF-)8}^{m k^r6ugddhNc{aqz>7;ma+22q_FvUu;JIk-}ackMs?Uu+3Oga7~l literal 0 HcmV?d00001 From b214e3577c41c690a552f528aa4b33e17def0f53 Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 14:13:55 +0200 Subject: [PATCH 02/15] [CHUX-465] create ec-mobile-header component --- .../ec-mobile-header/ec-mobile-header.vue | 41 +++++++++++++++++++ src/components/ec-mobile-header/index.ts | 1 + src/components/ec-mobile-header/types.ts | 3 ++ 3 files changed, 45 insertions(+) create mode 100644 src/components/ec-mobile-header/ec-mobile-header.vue create mode 100644 src/components/ec-mobile-header/index.ts create mode 100644 src/components/ec-mobile-header/types.ts diff --git a/src/components/ec-mobile-header/ec-mobile-header.vue b/src/components/ec-mobile-header/ec-mobile-header.vue new file mode 100644 index 000000000..825fc1c20 --- /dev/null +++ b/src/components/ec-mobile-header/ec-mobile-header.vue @@ -0,0 +1,41 @@ + + + + + diff --git a/src/components/ec-mobile-header/index.ts b/src/components/ec-mobile-header/index.ts new file mode 100644 index 000000000..b369c6cf2 --- /dev/null +++ b/src/components/ec-mobile-header/index.ts @@ -0,0 +1 @@ +export { default } from './ec-mobile-header.vue'; diff --git a/src/components/ec-mobile-header/types.ts b/src/components/ec-mobile-header/types.ts new file mode 100644 index 000000000..9eaa04bd9 --- /dev/null +++ b/src/components/ec-mobile-header/types.ts @@ -0,0 +1,3 @@ +export interface MobileHeaderProps { + isResponsive?: boolean, +} From c0ab58e45f0207319830eacdb747447852dc7bfa Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 14:15:15 +0200 Subject: [PATCH 03/15] [CHUX-465] add story --- .../ec-mobile-header.story.ts | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 src/components/ec-mobile-header/ec-mobile-header.story.ts diff --git a/src/components/ec-mobile-header/ec-mobile-header.story.ts b/src/components/ec-mobile-header/ec-mobile-header.story.ts new file mode 100644 index 000000000..eb5ac5f61 --- /dev/null +++ b/src/components/ec-mobile-header/ec-mobile-header.story.ts @@ -0,0 +1,40 @@ +import type { Meta, StoryFn } from '@storybook/vue3'; +import { ref, watchEffect } from 'vue'; + +import EcMobileHeader from './ec-mobile-header.vue'; +import type { MobileHeaderProps } from './types'; + +export default { + title: 'Layout/Mobile Header', + component: EcMobileHeader, +} as Meta; + +export const basic: StoryFn = storyArgs => ({ + components: { EcMobileHeader }, + setup() { + const isResponsive = ref(false); + watchEffect(() => { + const { + isResponsive: isResponsiveFromArgs, + } = storyArgs; + isResponsive.value = isResponsiveFromArgs!; + }); + return { + isResponsive, + }; + }, + template: ` + + + + `, +}); + +basic.args = { + isResponsive: true, +}; From 194bd4bc697a7f1e5d9b81df399a75826d29e0f6 Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 16:37:39 +0200 Subject: [PATCH 04/15] [CHUX-465] add unit tests --- .../ec-mobile-header.spec.ts.snap | 27 +++++++++++++ .../ec-mobile-header/ec-mobile-header.spec.ts | 39 +++++++++++++++++++ 2 files changed, 66 insertions(+) create mode 100644 src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap create mode 100644 src/components/ec-mobile-header/ec-mobile-header.spec.ts diff --git a/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap b/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap new file mode 100644 index 000000000..8eb1c711e --- /dev/null +++ b/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap @@ -0,0 +1,27 @@ +// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html + +exports[`EcMobileHeader > should render properly if "isResponsive" prop is true 1`] = ` +
+ + + + +
+`; diff --git a/src/components/ec-mobile-header/ec-mobile-header.spec.ts b/src/components/ec-mobile-header/ec-mobile-header.spec.ts new file mode 100644 index 000000000..b629dfbf4 --- /dev/null +++ b/src/components/ec-mobile-header/ec-mobile-header.spec.ts @@ -0,0 +1,39 @@ +import { type ComponentMountingOptions, mount } from '@vue/test-utils'; + +import EcMobileHeader from './ec-mobile-header.vue'; +import type { MobileHeaderProps } from './types'; + +describe('EcMobileHeader', () => { + const logoTemplate = ''; + + function mountMobileHeader(props?: MobileHeaderProps, mountOpts?: ComponentMountingOptions) { + return mount(EcMobileHeader, { + props: { + ...props, + }, + ...mountOpts, + }); + } + + it('should render properly if "isResponsive" prop is true', () => { + const wrapper = mountMobileHeader({ + isResponsive: true, + }, { + slots: { + logo: logoTemplate, + }, + }); + expect(wrapper.element).toMatchSnapshot(); + }); + + it('should not render the component if "isResponsive" prop is false', () => { + const wrapper = mountMobileHeader({ + isResponsive: false, + }, { + slots: { + logo: logoTemplate, + }, + }); + expect(wrapper.findByDataTest('ec-mobile-header').exists()).toBe(false); + }); +}); From 8c5c1ae2189fac15271c037a98fc3d520485510e Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 16:39:57 +0200 Subject: [PATCH 05/15] [CHUX-465] add exports in main.ts --- src/main.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main.ts b/src/main.ts index 3663dd64f..6aec96668 100644 --- a/src/main.ts +++ b/src/main.ts @@ -62,6 +62,8 @@ export { default as EcMetrolineItem } from './components/ec-metroline/components export * from './components/ec-metroline/components/ec-metroline-item/types'; export { METROLINE_PROVIDE_KEY } from './components/ec-metroline/provide'; export * from './components/ec-metroline/types'; +export { default as EcMobileHeader } from './components/ec-mobile-header'; +export * from './components/ec-mobile-header/types'; export { default as EcModal } from './components/ec-modal'; export * from './components/ec-modal/types'; export { default as EcMultipleValuesSelection } from './components/ec-multiple-values-selection'; From 03cb4449d326d3788bb6aa0f91f765dff6331698 Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 16:50:40 +0200 Subject: [PATCH 06/15] [CHUX-465] remove story from layout section since the component is not a layout --- src/components/ec-mobile-header/ec-mobile-header.story.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ec-mobile-header/ec-mobile-header.story.ts b/src/components/ec-mobile-header/ec-mobile-header.story.ts index eb5ac5f61..5c0281806 100644 --- a/src/components/ec-mobile-header/ec-mobile-header.story.ts +++ b/src/components/ec-mobile-header/ec-mobile-header.story.ts @@ -5,7 +5,7 @@ import EcMobileHeader from './ec-mobile-header.vue'; import type { MobileHeaderProps } from './types'; export default { - title: 'Layout/Mobile Header', + title: 'Mobile Header', component: EcMobileHeader, } as Meta; From 85835d9c79dcbf692fc35113f0035273975da85c Mon Sep 17 00:00:00 2001 From: Raul Aguilar Garcia Date: Thu, 16 May 2024 16:59:19 +0200 Subject: [PATCH 07/15] [CHUX-465] generate visual snapshots --- .../mobile-header--basic__chrome.snap.png | Bin 0 -> 7505 bytes .../mobile-header--basic__firefox.snap.png | Bin 0 -> 9344 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/integration/snapshots/visual-regression.spec.js/mobile-header--basic__chrome.snap.png create mode 100644 tests/integration/snapshots/visual-regression.spec.js/mobile-header--basic__firefox.snap.png diff --git a/tests/integration/snapshots/visual-regression.spec.js/mobile-header--basic__chrome.snap.png b/tests/integration/snapshots/visual-regression.spec.js/mobile-header--basic__chrome.snap.png new file mode 100644 index 0000000000000000000000000000000000000000..293f069e0afd4eccdf9ca8542e4a81d733fb3409 GIT binary patch literal 7505 zcmeHMYgAKL+NL@}E0?U*3lv0fX0Wsngy9Yeq-aMX&8t zToq6*K`u$^WFb{m#gB7# za+1CG^S=9epZ&gPU;ipG-g&pjZaX_W=Y-EcJ8oyU3;ei)_O?CPyvpU|+1c&=FyXVf zlhn87f69^V|DV%t(;6!e;99~hD%HZgV)ZiTE}~p*;-fY55F&c_p@CiCwJ^Pbv3={yyN@37joONo%s|z{t_kEBtw{%QeL02 zA9#pZ7)_+CnE)h9-jED{5bW#%PC@r?+x(#B)8r4J=7%N-u-%idA+UDm8g@X7| z&G>!jZg=5-+s#AgidZBvBY3cZkGh1fuflNQoR8WywY4WpuOI(hV>``!eAml zmI|&c9s|xf2RlRK6PlHg#TN};8SpRGf9X3)K9_>^`Wkxtty2AQAc=^$7|ClI zNnW!)uWPDRjVo>Ns9-O>e{rMsR3Te%vLfeFyn3$BrqyYI&p7stChnSJj9wC4FQ zL#pIt{?eb$_MWC2eh}>E z90e(pSY0E$aPboeNFM)~$I43oCH2y;*7dQFNu@ zG|ANloWPiiOKK(kYM(JgN2rXhxr{Duxj~ZqhF=0K1%`Yt^>am$*kqdk+KoLi6C+sh zTo1C^pI(+?`dJ#esclHq%LAis!+08L4|Sz#-FU4D9s}ebh&5lw1${oX(duOE^p99& zSMHS~(h4xHYWgb4rXZrKYG~Tzp5TAt6%WQ-%8bxhe)0{eQl4PNv2$*EIJKf`bT4qF zMLs6$(>lhYs==yi*=%Jjz4|KweK)GBo9EaCqImK*xWI}Wo8ZaKGKEil`!bn7v^D~l zWdWe~hx*l_V>Pl;JjK^K&{Gh;xz0!9iQz-N59OScjz?8a_L5r*xExeOX9q$aHc^I6 zBrZ5Wn7A#+Quo2q#w9Ja;##Tv%G6#55)~;USMA5TyO`@;TJ-)U%{uO(*+v(C<@`}# zhKvDF+$q^J2^@W4!GO?gCNYhB(r%SC%rg3pxM-znIGV7ayH&(NRKc!6ZbgHQYFYzPJlnO})Xy7VdTVED7fa_1nzVHd9sf3KP zQWd5tj#Fv9iK1BMT-;1s#WAnQ zPWD;Iw&{^Qx?N`DK%gGQQ4iwHM~JjcugEsGfkdE{_gpqzu(nltNxBO$!Hsdvv@ALb z1rcfGkWwqPg@O(STD+oo6p<0f)Ha|qgV7*D;W}S~sxgo(tC6Uc$C9IZLG4799$}lv zP)+jmmuEe+@tQn8fed(w4+mhe>nFJ?m9pRHv$-+nAN4R;s-Z4j7g>v!CWYaOND7{A zd4{Db=lrd&;uVG$IQ9}~*cx}%dKUr9%1jdKi+o3cKutb{J3g+2F;?!?s?@T)puuFc zmlW1*R5&?oiC^B!y(`nHvEJd{o(9Lva<{=z9J@&Z=SgtkO1Y;y3>YmdByA2qoBVb8 zSslX^)2^E-;)vEt4rGP%42KNO`V$z7c|0ShN}-Q>6e^Y9$i6x2&tE6f-Jk7?@Nlw^ zde~Wht#9^hc960cE@^aI<~ ze&K8{1dYIA_Zr^Y(`Efx*A2f>$Pz6)y)!9ndmmaK>H)s!Q#E7Ys%UxTzwCuV#Av^; zDz4N+8^uX-*9G{(v>4vxAjmX)y9Fq$qyQjB;WL*5&OnUCQ(2Qn3R3FA;xVML)kvPG zwMN3=mZVNftek|z#sj*`BUYq$bWcTnyQMXcde6)*bAUwcv718Anq@q62bs~<j%Ua=$m}iJk zq)O7LzYM3C@V3R2OLqluFt%bWd$I38z0;B$Vmm68g>r`h>%n`Bcb;=)Asj=Ab7^Cd zU!RET_EG4a;%iLp06 zR&V+Eo@j7mJ;TimLy1t#PN({nV zE^`wERmlM`Xm!;s-Lq$mN!YDToDuF9Na|Vq`7l$Pfi|R}F2~XZ*xb-6r2xUv36WhP z5+b*|mNN%;q_hO;#DDb1e&|$MH?wa{R+dsFGpEEd&qpYYM@bE$h2}n?KBgp1wv1yJ zMzjG>>K5RQP7c=U_Z&$1nOnqMA>1H+e_CCGJ4=rqVsKFpLpVB668hqDv+2P@Y65pd zg#>6eZ{GOikY@1lc7l zlNqq7UcOa$e6$kDg3AmNW2jIRA?ZC6G)Owt-xn9lL0w6Y8DPf?A0Q-p8{9jZ5(Yax zE)h1CSmX zqTw=p=_6R?{GEDoF21zV+Y_Htz(#dEDzk99YX@44nVFHY<9d)wt&2tt)2C-y4BPLn ztw`JW^gI4B1!2KpR);zwMrgLF33F1xIwgS^4@14q2lvmiIppRL(lLI34{G}WFlOos2n0p<@JqhbQea(h zcec0QDv1GiS@@V!DQG@OI7{1lU8T3Y!`@ow8&1kX%6g4|JHGr~AKWv^BlAJ1Ozu<$ z$LNG`m_HPjU1OD`v&8D}>1Fd@8n8*tacbs^uOO(?)(;7(Q`PmiO27odbo#l}NZ@vj zvd!O3jFQ150zccUV8&9J{z_0zFD3~$2fr|)MAgTf%?DSOHS0L$tLsH@#?X-xEnaN< zU`v4v8Rc0ZDkhH$YyyV=u9&$w+AKMaC)WvDG=0=;jgn z2wb$fn61uVy9)jC7&tZaXT!|*6V@5f>>Tl0#X#_z%yru8an0?iF`wN%hZOig47K!L zVovv=bs*nZJ}pt5Y@&D#EM`E{$bZ@$czbFN4&`L){VF-Zh&JDAC_|EH2rzweO>7R( z5j6#WpfnY2<;uM8k5PY`SL&^gg<$%I<|>PfF^@`nEY%3Jyxs+WlC_1*kp6z^`(Oez z^>P-Ommj8Ky!c8@GM~v!#!B;o-iH3dXg)l%i+tw%ZEyPQl=WeRdN1^}n(d;pM=)qH`P-$^Y0(kZp2plWUt?zv1oScHnFW&UWBz z2hP9aBw|}jwzcH{ua=lm6Re%@f)(cPJ{{g1-gtY3R|)8WJ>KH;qaV(FuqK1#QzNiXb$g7@}a(c)2PnmKQ0Cx)@mZo)3Xp8W zVo_F->{9fwXL@xpOxr{#=!;@LJ}600jmF$;Ubm+@{(ILXk98WgwN69>^hRpIQgDv4 zJ7M>lti{~{HIfVSf)&u5G#DH8@U|0(Ph1JujVB&pk3P029!<>s>`c0XnQ?hrkFXS;Jf^qJHsc| z>bpDleKT(FIO9IFi=yg~Cee*| zKyot2%+^s77V~E27q9Iz-R6&nl}qDw_SHkJ5FgcJ06<##m2F^TqXsjjFm4wFB_F*CKPDIM}$suqzk}(oRgd*%bQnrPymhZ zYc!WxuV>t+Y^@2i$HK&QbBT{TCLY0qA&}hRFjqxb&a<&;d0~j@3*#R8Yn=niOnKX=uu<(;tSjsDL2jv#Ov$Z zNA3aumz#?x=qLnLCbU~fr6$aYpy4N&{=GK^NEE7y#mdUbLEUmX;}xxZerqcq5?DmO z-thx+0VvMKV`=-4Rso*^kmx8p(T1m^5^X#wmp~y1$w%AmUr78tKL=oLq~pqQZX2q& zLY6=f$8_D9GLF!@OiFjT*(IAB&SG)W`)zpxHWOcRyUl4XzR*xOV-aziJ@(W{x^j%& zE-jn!zB}#E^gA9LKdle73bN<%6uUMS>MK*BQuywf!i^Ec%s?iwk;H2Q1feOTspiXT z*JO(`2^Een6mrj%fEfiuGL|i03{*G*#PWyD9s-TSdU|cH`gnV&D1U*_R(o~r=G_m!W9g}q3|$dgX^m)fB47F&!~`NVJD7Sc+!lcbmk>gjx1xI`6ai3 zBwO=FS3--W;G-u6Vp(Gc;^Wrr=g&0vB;-KsU~>(X3W@kOHBr9uM833oK1wk-!Vd4r zcy&@dMclonTp@)o*;*knpjshWy@o67D7H6A{EV>MU)Dl_dj|Z3Xm1R-qctn7bytd& zj98wwc)Yv0SO_3kwmI*x&D4B_rhHJR#0G@$wZXyzQ6)F1bu<5ilms_U;`2d`#Gk2N zUlYm;r8kp8{MVE$9wEz-K}XJQ@zC-`3-h|mpxfimoQT_FC-h4?*aTHQGFOy2ulz_V zUmdI6H+dVZ>*k(PeS@riJ|gU4(b#EV&#nmdk{rCZhs(5uz>RVCzU98xr(eob{eT*Iz_zRTR%b^x!k zbTICRc={TNmRj)Gk~Xw-p-Vikd@33V*j$?P>gF8Er3d?_V;gVfFF-$tCZI1a9olOx z!7(nzWVa=+vTE-gQ9wp~Bsz(-pT8{Iw3%E;v7;kbw^S?cq7O$LNt3m*%)05jMp8eE8P`K zE~ZOhipSQl7X?AG^^ypU46H9KpR8hN89e9AURoJubEUda{n!=lgMi9BF)bU;e&m@% zJE%NJX5bho;W;SneW?>bUcj>gC)fsjr>Oy)ER;n@M2mS>O0*pyN8sLPyzl*XPX)=$ zwwyCx%HmQY96~oRTBUhshI>9WDoMmo*0Hsb#tV3gDoff8wDh(}odW1k z^Um`I@DnhXyXKlg;kgW4N{1 ztevjl@_9U+`Cg(e2j6Dar*aH+KnwVp@0NwT8-hjUD@J13V6}Zd@r0O46yypF8~`T! zR;al1`KT(P0D2V=7_1K+WNv!O+=MQrp~HULKxqTyiyPJCyrq^!8)yk?WSU$wY#JSo$pxZ@JEH2Y%}~8I!a<-;0YA^Tw*xWRC2;` zea)?#P|06?SF&VGwHVH)&fzH>?o93D(AZM<_c{JTCk~|3E@Ey;yLbBv=Q8CcbcU$o z?CW5)nI#SI1r|4fJ6@4JkA>xcrIqBOv~9`ZvWn86AvDC}beoGUXK%*p>^uW3RLF-+S%{~T*_g~wd% z*^6$9r=w~-yqY_B0@1RUIV$aE8h;k~W?i0&Uez4O?b1vS@Sszm_F;*QoPZSyApJNy z+}Oz4t*;-TA&;n@j*cMaJdzjmLQJhXOUbC+EV12-8l*yp_K*_I47V{u8b3WXf}Un1 z|7H$iHJHjLqp-aIIVCpcH(dTKHV0MXgSRH_jOFQ-WDYQZ8Q#%T10F)%l42xWBwVDp zNR|yg$gb(jnAqh3f8A=dd#P7$eW~z1wq6H+j4&4;4R|N4c=p3oC}QBn$(=6X*JA;K zpu%Z&Gx{bh)Sjdcwq0M^q#UepmoxQih~cYX{g4X)T0&sCHrD~jR1tq4Ya))#40d#P z-=W$d!@WsnJbbFoU=&`3Y-AX-q)8mO*u`cxEH*F`vb2dVvm;3)-PZ@sl4vD)0B-Um z!M?+dX&CY@n6ky4r>3WrDYV|k#+p3KC%@XG>}1)acIm!`R`4^}dWH+Q*@n92)hku@ zxY9Ir!1QO)Y->s21chRYy3Nv{CUQ`)!(+{pKZfDYE~fdwMIqSlWAT$y8sDjUQu6t3 zs+f!tg`$*TX6{7;BbGS{05gei%tLe(LLjxWW%p2;r$Hui7TYU zER->o7&XRmnkBbcyA!p!^8$li$=YoNm>gqnZ4;BA+9l2Fo_SRb3~pB9IF&9BdPW-Y zSI(|R2gb5+t_e|L8*;2v?KU=Wqb^9w^x4fLnkQlY)&r@M5y9fMc&u?anjb*f7&6sZ zCJPnOurIw}s_WNA*b_@}^@#G#b@B?}vvQK^OkBmw{jk*c9MNjz;@A*u^N(y6J?adR z9FMJb)f?D7XxOJ^UPj7z7#z;Jekluid{=QeKWPEt;{Gm53{w; z-+c}lo|cB&c|{v5qnH$U(*xFb5E?lpF!~HQb?#<2x2N*Z=6amaJ6Pq0c@8d50flA2 zGNb5sca2&E~SUirIce##5-S3v0lR&&|R)Ukr-9$s;EiP^FI*!zaNjlbHQSp#DtTc>-w=qf82j)vd;81K)hNYo0Nu9YbTCOKPnilp-X zvW8HvbhM&aN7w4R`d;?!o6qrOnHREB`1rldNbTDzUk;qq>Fb=Mr)*d}fo>h^PSDx& zRuk#z5S4j@lVtQnu(pX%$Tw@Rc>AaOV-bBt;i~ayk<=MH)PuI0 zBBHpJPCK39GGK^fy2Nq2qM4m$S-)s@ey0dCBxbR*Bk8DQRK%2VxYxw`*j%Ji=1Ji& zu>5^gKQ&|Eh>B4fDGc&;>q$|f{#YBOwUFdv$X01`d)MLSUJPU93##iUE8{+RfD-Oe zO&~^7ahIZ1OmKnGq+i44SLAvK(^n z4}x+b$QylEWiML#OS=6zDfXCXzEhz~YHI zHq5#z{x|LxMgFC&^xfRa{L`4dih|1*flNIG zcNbi*S%Q#DW&bV#4_g<5JpB<^o`}4a6LD#dWqAWje5OlshoupW(T&I7Rp5%2_9Ob9>ABTTBWAKO)l(ZG z!!=9$Yt3~AimxGG=nn;GtKmCeilkO7c}ezJS~$5&-`i7c)r3uN%J}vp%_SHgP+P76 zUjJoUHJAK^rpX*Py!*>|4+IF4>`2SgW?4 zuVlRKd+*sZ|NOxb)F0z(MZYIWTf Date: Fri, 17 May 2024 10:25:08 +0200 Subject: [PATCH 08/15] [CHUX-465] remove mobile header prop as it is not needed --- .../ec-mobile-header.spec.ts.snap | 2 +- .../ec-mobile-header/ec-mobile-header.spec.ts | 21 ++---------------- .../ec-mobile-header.story.ts | 22 ++----------------- .../ec-mobile-header/ec-mobile-header.vue | 4 ---- src/components/ec-mobile-header/types.ts | 3 --- src/main.ts | 1 - 6 files changed, 5 insertions(+), 48 deletions(-) delete mode 100644 src/components/ec-mobile-header/types.ts diff --git a/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap b/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap index 8eb1c711e..3dfe6637c 100644 --- a/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap +++ b/src/components/ec-mobile-header/__snapshots__/ec-mobile-header.spec.ts.snap @@ -1,6 +1,6 @@ // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html -exports[`EcMobileHeader > should render properly if "isResponsive" prop is true 1`] = ` +exports[`EcMobileHeader > should render properly 1`] = `
{ const logoTemplate = ''; - function mountMobileHeader(props?: MobileHeaderProps, mountOpts?: ComponentMountingOptions) { + function mountMobileHeader(mountOpts?: ComponentMountingOptions) { return mount(EcMobileHeader, { - props: { - ...props, - }, ...mountOpts, }); } - it('should render properly if "isResponsive" prop is true', () => { + it('should render properly', () => { const wrapper = mountMobileHeader({ - isResponsive: true, - }, { slots: { logo: logoTemplate, }, }); expect(wrapper.element).toMatchSnapshot(); }); - - it('should not render the component if "isResponsive" prop is false', () => { - const wrapper = mountMobileHeader({ - isResponsive: false, - }, { - slots: { - logo: logoTemplate, - }, - }); - expect(wrapper.findByDataTest('ec-mobile-header').exists()).toBe(false); - }); }); diff --git a/src/components/ec-mobile-header/ec-mobile-header.story.ts b/src/components/ec-mobile-header/ec-mobile-header.story.ts index 5c0281806..326b7c7cd 100644 --- a/src/components/ec-mobile-header/ec-mobile-header.story.ts +++ b/src/components/ec-mobile-header/ec-mobile-header.story.ts @@ -1,30 +1,16 @@ import type { Meta, StoryFn } from '@storybook/vue3'; -import { ref, watchEffect } from 'vue'; import EcMobileHeader from './ec-mobile-header.vue'; -import type { MobileHeaderProps } from './types'; export default { title: 'Mobile Header', component: EcMobileHeader, } as Meta; -export const basic: StoryFn = storyArgs => ({ +export const basic: StoryFn = () => ({ components: { EcMobileHeader }, - setup() { - const isResponsive = ref(false); - watchEffect(() => { - const { - isResponsive: isResponsiveFromArgs, - } = storyArgs; - isResponsive.value = isResponsiveFromArgs!; - }); - return { - isResponsive, - }; - }, template: ` - +