[ONL-8261] Migrate smart-table and filters to TS #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mcibique
force-pushed
the
ONL-8261-migrate-smart-table-and-filters
branch
from
f519bad to
2da1e5a
Compare
mcibique
requested review from
derrick-g,
stavros-tomas,
wolandec and
corinaper
as code owners
corinaper
approved these changes
Feb 22, 2024
derrick-g
approved these changes
Feb 22, 2024
stavros-tomas
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit by commit.
Migrated filters and all dependencies:
EcFilterPopover
EcAmountFilterInput
EcDateRangeFilter
EcSyncMultipleValuesFilter
EcSubmenu
EcLoadingIcon
And used the filters in EcTableFilter and EcSmartTable