Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMIP3 data entries to align with ESGF #3304

Closed
wants to merge 1 commit into from

Conversation

rbeucher
Copy link
Contributor

Description

CMIP3 data entries in recipes are specified in a way that is only compatible with the DKRZ data pool. For example, in https://github.com/ESMValGroup/ESMValTool/blob/main/esmvaltool/recipes/bock20jgr/recipe_bock20jgr_fig_1-4.yml#L242-L249, we have:
exp: 20c3m, frequency: mo, realm: atm
while the ESGF facets are:
exp: historical, frequency: mon, realm: atmos

I have updated the recipes so it can work with ESGF and the data pool with have at NCI.
I suppose you will need to update the ones at DKRZ


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very many thanks @rbeucher 🍺 I am approving this from a technical point, but I am adding Lisa @LisaBock and Katja @katjaweigel as scientific reviewers. Fors a spot of advice, have a look at these points below:

  • it'd be good, when changing recipes, to add the recipe maintainers as reviewers (let me know if you are not fully added as contributor to ESMValTool, I'll add you and ping @axel-lauer to send you the welcome package)
  • could you please edit the PR description to check the boxes that need be checked for the PR (that are relevant to the PR), and either remove the ones that are not relevant, or somply strikethrough them with ~blah~ in Markdown syntax
  • you can use the runner bot (although it may not work always) by eg posting a comment summoning it for a recipe run @esmvalbot please run examples/recipe_python.yml

Cheers 🍺

@LisaBock
Copy link
Contributor

LisaBock commented Aug 4, 2023

Hi @rbeucher ! Thanks for your PR.
I tried it with ESGF downloading and got the following error message:
ValueError: File ESGFFile:cmip3/CSIRO-QCCCE/csiro_mk3_0/historical/mon/atmos/run1/tas/v1/tas_A1.nc on hosts ['aims3.llnl.gov'] dates do not match a recognized pattern and time can not be read from the file

Have you tried the recipes with downloading form ESGF?

@rbeucher
Copy link
Contributor Author

rbeucher commented Aug 4, 2023

Yes I was gonna change that. Sorry.

@rbeucher
Copy link
Contributor Author

rbeucher commented Aug 7, 2023

Thanks @valeriupredoi . I think I need to be added as a contributor. I can't request a review from maintainers.

@rbeucher
Copy link
Contributor Author

rbeucher commented Aug 7, 2023

Not sure how to fix the issue. I will have to look closer at the file. The code does not seem to extract the time information from the file.

@LisaBock
Copy link
Contributor

LisaBock commented Aug 7, 2023

The problem with CMIP3 is that the time information is not part of the file name.

@valeriupredoi
Copy link
Contributor

Thanks @valeriupredoi . I think I need to be added as a contributor. I can't request a review from maintainers.

OK I'll add you here if that's cool with @axel-lauer too, and Axel will send you the "welcome email" as well. Before I open the PR to add you to the contributors' list, could you pls tell me your institution that you wish to be affiliated with, and an ORCID number (if you has one) 🍺

@rbeucher
Copy link
Contributor Author

rbeucher commented Aug 8, 2023

Sure

Romain Beucher
ACCESS-NRI
0000-0003-3891-5444

@valeriupredoi
Copy link
Contributor

cheers! Will start the procedures tomorrow 👍

@axel-lauer
Copy link
Contributor

Welcome to the development team, @rbeucher!

@valeriupredoi
Copy link
Contributor

for your consideration gents @axel-lauer @rbeucher #3318

@zklaus
Copy link

zklaus commented Nov 3, 2023

I am not completely sure what the status of this PR is, but my understanding is that it needs a bit more work? I'll bump it to the next milestone, but if I am wrong and this can essentially be merged as is, please let me know.

@zklaus zklaus added this to the v2.11.0 milestone Nov 3, 2023
@rbeucher rbeucher self-assigned this Jan 24, 2024
@mo-gill
Copy link
Contributor

mo-gill commented May 2, 2024

Hi, we are currently working on the ESMValTool release for v2.11.0. We're wondering if you'd be able to complete this PR by the end of next week (Friday 10th May).

Otherwise, please let us know, and we'll move it into the next milestone for you 🙂

@valeriupredoi
Copy link
Contributor

valeriupredoi commented May 3, 2024

I too am curious about the status of this PR - would be a rather useful one to merge the sooner the better 👍 @mo-gill @ehogan would you guys be OK to create an M2.12 milestone please, so we can move stuff (hopefully not like this) to the next milestone? 🍺

@mo-gill
Copy link
Contributor

mo-gill commented May 7, 2024

create an M2.12 milestone please

I'm hoping i've done this correctly! 🤞 https://github.com/ESMValGroup/ESMValTool/milestone/15

Wasn't sure what the due date should be, or whether i should leave it blank for the time being? @valeriupredoi @ehogan

@ehogan
Copy link
Contributor

ehogan commented May 7, 2024

create an M2.12 milestone please

I'm hoping i've done this correctly! 🤞 https://github.com/ESMValGroup/ESMValTool/milestone/15

Wasn't sure what the due date should be, or whether i should leave it blank for the time being? @valeriupredoi @ehogan

We added the due date to the v2.11.0 milestone when we knew when we were doing the v2.11.0 release, so the next release manager will update the due date for the v2.12.0 milestone when they know when they are doing the release 👍

@rbeucher
Copy link
Contributor Author

rbeucher commented May 9, 2024

This is not ready to merge unfortunately.
I need to retrieve the time information which is not available via the file name ... Any suggestions @valeriupredoi ?

@flicj191
Copy link
Contributor

flicj191 commented May 9, 2024

This is not ready to merge unfortunately. I need to retrieve the time information which is not available via the file name ... Any suggestions @valeriupredoi ?

I had a look too and if the files are local it works fine as long as it can find it and get the time information from the file but if it needs to download ESGF file it can't get the time information ... so would have to change in esmvalcore to download these types of files first?? or file name change on ESGF node?

@mo-gill mo-gill modified the milestones: v2.11.0, v2.12.0 May 24, 2024
@rbeucher
Copy link
Contributor Author

Given the transition to CMIP7 and the diminishing likelihood of CMIP3 being supported on ESGF, I believe it is time to conclude this.

@rbeucher rbeucher closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CMIP3 data entries in recipe to align with ESGF facets
8 participants