-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed automatic conversion of precipitation units from monitoring diagnostic #3049
Conversation
To use the unit conversion in the new version of this diagnostic, add the following preprocessor for the precipitation dataset to the recipe: convert_units:
units: mm day-1 |
@esmvalbot Please run monitor/recipe_monitor_with_refs.yml |
ESMValBot is happy to report recipe monitor/recipe_monitor_with_refs.yml ran OK, output has been generated here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you not want to add the conversion preprocessor to the recipe? Apart from that - one of the easiest reviews ever 😁
The recipe uses temperature and not precipitation - so no, I don't want to add that 😅 |
surely some American will complain their temperature is indeed measured in |
@remi-kazeroni you wanna merge this, bud? Unless you think temperature is measured in |
@schlunma, could you please move or duplicate these instructions to the description PR? This would help the release manager to draft the changelog 🍻 This can then be merged. Thanks! |
Done! |
Thanks for your contribution @schlunma and the review @valeriupredoi! |
Description
Currently, the diagnostic
monitor/multi_datasets.py
automatically converts precipitation units fromkg m-2 s-1
tomm day-1
even if the user does not ask for this. The reason for this was that ESMValCore was not able to do that conversion in the preprocessor.Since ESMValGroup/ESMValCore#1574 and ESMValGroup/ESMValCore#1837 this conversion is now possible; thus, the conversion can be removed from the diagnostic.
How to change recipes?
To use the unit conversion for precipitation in the new version of this diagnostic, add the following preprocessor for the precipitation dataset to the recipe:
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: