Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some recipes are broken after new ESMValCore release v2.0.6b. #1522

Closed
Peter9192 opened this issue Feb 12, 2020 · 0 comments · Fixed by #1523
Closed

Some recipes are broken after new ESMValCore release v2.0.6b. #1522

Peter9192 opened this issue Feb 12, 2020 · 0 comments · Fixed by #1523

Comments

@Peter9192
Copy link
Contributor

Peter9192 commented Feb 12, 2020

Describe the bug
The new release changes the way fixes work. This leads to 2 types of errors in test_recipes.py:

  1. Recipes that are now broken due to missing key mip. Here, the mip needs to be added to the recipes. This affects the following recipes:
  • recipe_validation.yml
  • recipe_validation_CMIP6.yml
  • recipe_autoassess_radiation_rms_cfMon_all.yml
  • recipe_autoassess_radiation_rms_Amon_obs.yml
  • recipe_autoassess_radiation_rms_Amon_all.yml
  1. Tests failing because the test calls fix_metadata after get_reference_levels. In this case only the tests are broken, not the recipes themselves. These tests can be fixed by changing the test, e.g. by adding a mock. This affects the following recipes:
  • recipe_perfmetrics_CMIP5.yml
  • recipe_collins13ipcc.yml
  • recipe_smpi_4cds.yml
  • recipe_perfmetrics_CMIP5_4cds.yml
  • recipe_smpi.yml
  • recipe_preprocessor_test.yml
  • recipe_correlation.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant