Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unit=1 if anomalies are standardized #727

Merged
merged 4 commits into from
Aug 17, 2020
Merged

Conversation

bascrezee
Copy link
Contributor

@bascrezee bascrezee commented Jul 22, 2020

Closes #726. @hb326 Can you test in combination with the MPQB framework?

@bascrezee bascrezee added bug Something isn't working preprocessor Related to the preprocessor labels Jul 22, 2020
@bascrezee bascrezee self-assigned this Jul 22, 2020
@bascrezee bascrezee marked this pull request as ready for review July 30, 2020 13:33
@bascrezee
Copy link
Contributor Author

@hb326 Can you test?

@bascrezee bascrezee requested a review from jvegreg July 30, 2020 13:34
Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please modify the tests in tests/unit/preprocessor/_time/test_time.py#1015 to account for this change?

@bascrezee
Copy link
Contributor Author

bascrezee commented Aug 5, 2020

@hb326 Did you test? I can already tell that we run into a few issues that have to be solved. See the linked issue.

@hb326
Copy link
Contributor

hb326 commented Aug 6, 2020

@bascrezee: I did test it just now. Does not work for the MPQB.
See the following error message:
ValueError: Unable to convert from 'Unit('1')' to 'Unit('kg m-2 s-1')'.
2020-08-06 09:41:58,509 UTC [44220] INFO If you suspect this is a bug or need help, please open an issue on https://github.com/ESMValGroup/ESMValTool/issues and attach the run/recipe_*.yml and run/main_log_debug.txt files from the output directory.

Seems to me it is the same error as you reported in #741

@hb326
Copy link
Contributor

hb326 commented Aug 7, 2020

I ran the MPQB recipe again, with the inlcuded changes to the preprocessor.
Good news: it ran through!
Not so good news: I am missing the units at the y-axis... Are there supposed to be units?
lineplot_pr_1983-2016

@bascrezee
Copy link
Contributor Author

bascrezee commented Aug 7, 2020

Can you check the units of the preprocessor output? ncdump -h I would expect them to be 1.

@hb326
Copy link
Contributor

hb326 commented Aug 10, 2020

Can you check the units of the preprocessor output? ncdump -h I would expect them to be 1.

@bascrezee: yes, the unit is 1 in the preprocessor output.

@bascrezee
Copy link
Contributor Author

Good. Than all is fine I would say, the units not being shown at the y-axis there is Iris behaviour (iris.quickplot.plot). Apparently it defaults to not showing in this case, which is fine. I am now working on the tests as requested by @jvegasbsc.

@bascrezee bascrezee requested a review from jvegreg August 10, 2020 08:38
@bascrezee
Copy link
Contributor Author

Can this be merged?

@jvegreg jvegreg merged commit 3e9eca7 into master Aug 17, 2020
@jvegreg jvegreg deleted the std-anoms-are-unitless branch August 17, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardized anomalies should be unitless.
4 participants