Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added various fixes for hybrid height coordinates #562

Merged
merged 9 commits into from
Apr 1, 2020
Merged

Added various fixes for hybrid height coordinates #562

merged 9 commits into from
Apr 1, 2020

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 9, 2020 •
edited
Loading

This PR adds fixes for cl, cli and clw datasets with a hybrid height coordinate.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Related to #537. (Note: Automatic closing of these issues is not desired; they should be closed when the issue is reported to the modelers).

@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Mar 9, 2020
@schlunma schlunma requested review from zklaus and valeriupredoi March 9, 2020 15:47
@schlunma schlunma self-assigned this Mar 9, 2020
@schlunma schlunma mentioned this pull request Mar 9, 2020
Closed
@schlunma schlunma added this to the ESMValTool papers milestone Mar 10, 2020
valeriupredoi
valeriupredoi approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy cheese, there are a lot of fixes here - well done, man! One comment: it would be very useful if we documented proper all funcs in esmvalcore/cmor/_fixes/shared.py so that they can be used via the API - not necessarily here, but we should have that in mind (open an issue) for the future 🍺

@schlunma

This comment has been minimized.

Sign in to view
@schlunma schlunma force-pushed the fix_hybrid_height branch from 7a4c16c to 8a1efb8 Compare March 12, 2020 16:28
@schlunma

This comment has been minimized.

Sign in to view
@schlunma schlunma requested a review from valeriupredoi March 13, 2020 13:36
@schlunma schlunma mentioned this pull request Mar 16, 2020
Merged
10 tasks
@schlunma

This comment has been minimized.

Sign in to view
@valeriupredoi

This comment has been minimized.

Sign in to view
@schlunma

This comment has been minimized.

Sign in to view
@bouweandela

This comment has been minimized.

Sign in to view
@bouweandela bouweandela self-requested a review March 24, 2020 20:49
@schlunma

This comment has been minimized.

Sign in to view
@schlunma schlunma force-pushed the fix_hybrid_height branch from 0079f85 to 9311e21 Compare March 25, 2020 15:43
@schlunma
Copy link
Contributor Author

@bouweandela I implemented your suggestion and refactored the code again (hopefully for the last time now). Can you take another look at it? Thanks!

@schlunma
Copy link
Contributor Author

@bouweandela I implemented your suggestion and refactored the code again (hopefully for the last time now). Can you take another look at it? Thanks!

@bouweandela? Sorry for the hurry, but I really need this for a diagnostic used in Axel's paper 😬

bouweandela
bouweandela approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me apart from some very minor suggestions, but I would really like a review of @zklaus or @jvegasbsc as well, because I'm no expert on the cf-conventions.

esmvalcore/cmor/_fixes/shared.py Outdated
return func


ALTITUDE_TO_PRESSURE = _get_altitude_to_pressure_func()

This comment was marked as resolved.

Sign in to view

esmvalcore/cmor/_fixes/shared.py Outdated
List of cubes which contains the desired coordinate bounds as single
cubes.
coord_var_names : list of str
``var_name``s of the desired coordinates (without suffic ``_bnds`` or

This comment was marked as resolved.

Sign in to view

@bouweandela bouweandela requested a review from jvegreg March 31, 2020 10:00
jvegreg
jvegreg approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @bouweandela said, code looks good. I am a bit lost with atmosphere hybrid coordinates, so I can not provide any more comments

@mattiarighi mattiarighi merged commit 6624825 into master Apr 1, 2020
@mattiarighi mattiarighi deleted the fix_hybrid_height branch April 1, 2020 12:35
@bouweandela bouweandela mentioned this pull request Apr 2, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouweandela bouweandela bouweandela approved these changes

@jvegreg jvegreg jvegreg approved these changes

@zklaus zklaus Awaiting requested review from zklaus

@valeriupredoi valeriupredoi Awaiting requested review from valeriupredoi

Assignees

@schlunma schlunma

Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Milestone
ESMValTool papers
Development

Successfully merging this pull request may close these issues.
5 participants
@schlunma @valeriupredoi @bouweandela @jvegreg @mattiarighi