-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pinned python lower than 3.8 #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also pin in meta.yaml?
@jvegasbsc This is one of those cases where it would have been nice not to have numba as a dependency. |
fairly sure it's not just Numba that's been caught sleeping, man |
done, bro |
Do we need to address this in the https://github.com/ESMValGroup/ESMValTool repository as well? |
Could you please post the list? This way we will know when we can move back to normal. |
no, the environment is restrictive enough not to allow conda to update Python (I just tested) |
I would have done that if I had a list. Unfortunately it was stopping at Numba compilation. We could turn it off (remove Numba from deps) and try again to see where next it may stop but I think it may be overkill for now |
Well, numba is really special in that it is affected by the changes to the internal byte-code format in python 3.8, so if there is no extra reason to belief otherwise it seems reasonable to assume that no other package has problems. |
I think the only other package affected was fiona, you can look this up in
the installation log file, which is recorded as an artifact by circle ci.
…On Mon, 18 Nov 2019, 15:21 Klaus Zimmermann, ***@***.***> wrote:
Well, numba is really special in that it is affected by the changes to the
internal byte-code format in python 3.8, so if there is no extra reason to
belief otherwise it seems reasonable to assume that no other package has
problems.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#376?email_source=notifications&email_token=ABJN5GK6MCA7JD5BS4IB2RTQUKQFHA5CNFSM4JN2NBJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKSWLY#issuecomment-555035439>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJN5GMXJSMLWZV3EVNSF7TQUKQFHANCNFSM4JN2NBJQ>
.
|
And I believe we're actually using some deprecated functions that have been
removed in Python 3.8 to check that there are no invalid preprocessor
arguments in the recipe, so we might need to update
esmvalcore/preprocessor/__init__.py too before it works.
|
Bunch of packages from our environment are not yet able to deal with
python=3.8
that gets picked up automatically by anenv update
orupdate all
(egnumba
and possible a bunch more). Can we get this in asap, please 🍺