Development fx area and volume #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
added
enhancement
Merged
|
Thanks V! |
|
Related issue #94, see also the discussion there. |
9 tasks
|
@ledm would you be ok if you merged |
bouweandela
reviewed
Oct 15, 2019
esmvalcore/preprocessor/_area.py
Outdated
| if cube.coord('latitude').ndim == 1: | ||
| region_subset = cube.intersection( | ||
| longitude=(start_longitude, end_longitude), | ||
| latitude=(start_latitude, end_latitude)) | ||
| region_subset = region_subset.intersection(longitude=(0., 360.)) | ||
| return region_subset | ||
| # irregular grids | ||
|
|
||
| # Irregular grids - not lazy. |
There was a problem hiding this comment.
These changes are no longer needed, this has been fixed.
|
this needs revival 🍺 |
|
Nope! these changes are obsolete, all is done up in |
|
This problem is not solved: #367 |
|
s**t, sorry mate The branch is old as time and I am afraid I don't have the time to resolve all the conflicts in |
19 tasks
|
Please close and delete branch if no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you start, please read CONTRIBUTING.md.
Tasks
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #367