You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, the multi_model_statistics preprocessor function is by default executed before any temporal/spatial statistics preprocessor functions. This is computationally inefficient and possibly less accurate, because it introduces the need for extra regridding/vertical interpolation before the multimodel statistics can be computed. Therefore I propose to move multi_model_statistics all the way to the end of the default order, after convert_units. Does anyone have an opinion on this @ESMValGroup/esmvaltool-developmentteam?
To explain the above a bit more clearly, here are some examples of preprocessing chains that users could build:
Current implementation:
2D input -> regrid -> multimodel stats -> area stats
3D input -> extract levels -> regrid -> multimodel stats -> volume stats
daily input -> multimodel stats (fails because of 360 day + 365 day calendars) -> monthly statistics
Whereas if we would move multimodel stats to the end, the above examples would simplify to
2D input -> area stats -> multimodel stats
3D input -> volume stats -> multimodel stats
daily input -> monthly statistics -> multimodel stats (works because all calendars have 12 months)
so we would lose the regrid and extract levels functions that introduce inaccuracies.
In all recipes currently in the esmvaltool, the custom_order option is used to change the order to the new default order proposed above. This are recipes:
recipe_kcs.yml
recipe_ocean_Landschuetzer2016.yml
recipe_ocean_example.yml
recipe_ocean_bgc.yml
The only exception to this is recipe_carvalhais14nat.yml, with
At the moment, the multi_model_statistics preprocessor function is by default executed before any temporal/spatial statistics preprocessor functions. This is computationally inefficient and possibly less accurate, because it introduces the need for extra regridding/vertical interpolation before the multimodel statistics can be computed. Therefore I propose to move
multi_model_statistics
all the way to the end of the default order, afterconvert_units
. Does anyone have an opinion on this @ESMValGroup/esmvaltool-developmentteam?To explain the above a bit more clearly, here are some examples of preprocessing chains that users could build:
Current implementation:
Whereas if we would move multimodel stats to the end, the above examples would simplify to
so we would lose the regrid and extract levels functions that introduce inaccuracies.
In all recipes currently in the esmvaltool, the
custom_order
option is used to change the order to the new default order proposed above. This are recipes:The only exception to this is recipe_carvalhais14nat.yml, with
but that already uses
custom_order
to moveregrid
beforemask_landsea
, so it would not be affected by this change.For reference: the current default preprocessor order:
ESMValCore/esmvalcore/preprocessor/__init__.py
Lines 99 to 161 in 695fc48
The text was updated successfully, but these errors were encountered: